Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AndroidManifest.xml - remove package value from manifest #298

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

roiberlin
Copy link

getting issue when trying to build my project

this is the error that I am getting

FAILURE: Build failed with an exception.

  |  
  | * What went wrong:
  | Execution failed for task ':react-native-biometrics:processDebugManifest'.
  | > A failure occurred while executing com.android.build.gradle.tasks.ProcessLibraryManifest$ProcessLibWorkAction
  | > Incorrect package="com.rnbiometrics" found in source AndroidManifest.xml: /Users/builder/uibuilder/work/working-dir/node_modules/react-native-biometrics/android/src/main/AndroidManifest.xml.
  | Setting the namespace via the package attribute in the source AndroidManifest.xml is no longer supported.
  | Recommendation: remove package="com.rnbiometrics" from the source AndroidManifest.xml: /Users/builder/uibuilder/work/working-dir/node_modules/react-native-biometrics/android/src/main/AndroidManifest.xml.

from android documentation

In the Gradle-based build system, starting with AGP 7.3, don't set the package value in the source manifest file directly. For more information, see Set the application ID.

@roiberlin roiberlin marked this pull request as draft November 10, 2024 21:09
add namespace
@roiberlin roiberlin marked this pull request as ready for review November 10, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant